fix: establish native exception mechanisms#5052
Merged
supervacuus merged 4 commits intomainfrom Jan 23, 2026
Merged
Conversation
supervacuus
requested review from
adinauer,
lcian,
markushi and
romtsn
as code owners
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dba088c | 333.98 ms | 381.16 ms | 47.18 ms |
| 91bb874 | 310.68 ms | 359.24 ms | 48.56 ms |
| d15471f | 315.61 ms | 360.22 ms | 44.61 ms |
| 27d7cf8 | 314.17 ms | 347.00 ms | 32.83 ms |
| a5ab36f | 316.83 ms | 394.54 ms | 77.71 ms |
| 5b66efd | 308.67 ms | 363.85 ms | 55.18 ms |
| abfcc92 | 337.38 ms | 427.39 ms | 90.00 ms |
| fc5ccaf | 279.11 ms | 353.34 ms | 74.23 ms |
| fcec2f2 | 328.91 ms | 387.75 ms | 58.84 ms |
| dba088c | 365.46 ms | 366.31 ms | 0.85 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
| 91bb874 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| a5ab36f | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| 5b66efd | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
romtsn
reviewed
Jan 23, 2026
Comment on lines
7
to
9
| TOMBSTONE("tombstone"), | ||
| SIGNAL_HANDLER("signalhandler"), | ||
| TOMBSTONE_MERGED("tombstone_merged"); |
Member
There was a problem hiding this comment.
Suggested change
| TOMBSTONE("tombstone"), | |
| SIGNAL_HANDLER("signalhandler"), | |
| TOMBSTONE_MERGED("tombstone_merged"); | |
| TOMBSTONE("Tombstone"), | |
| SIGNAL_HANDLER("signalhandler"), | |
| TOMBSTONE_MERGED("TombstoneMerged"); |
I think we're really inconsistent with naming across SDKs, but we tend to use camelCase in the Java SDK, so I'm thinking if we could change that? signalhandler probably has to stay as-is to not break existing filters, but the new ones we may change to follow camelCase
romtsn
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
As discussed yesterday during the sync, let's establish native exception mechanisms right away.
💡 Motivation and Context
allows us to cleanly differentiate which handler an event originated from. This is particularly helpful since we now also merge events from two different mechanisms: #5037
💚 How did you test it?
adapted the affected unit tests.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps